merge py2 and py3 argparse #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| conflict_handler: str = ..., | ||
| add_help: bool = ...) -> None: ... | ||
| def add_argument(self, | ||
| *name_or_flags: Union[str, List[str]], |
There was a problem hiding this comment.
From docs.python.org, we can have parser.add_argument('-f', '--foo'), so that seems correct to me.
There was a problem hiding this comment.
I meant: You can only have one "varargs" argument in a function definition. Maybe you need to remove the single "" below?
There was a problem hiding this comment.
Ho, I see what you mean, correct, that's a typo (fixed).
81da6f4 to
87235ad
Compare
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add types to argparse, merge both version. There is some undocumented (in general, argparse is badly documented on docs.python.org) element which I removed (thus being more implementation agnostic), but I keep some used by mypy, let me know if something break.
for example
help(argparse.HelpFormatter)but mypy use the
__init__of it.