Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ast: add visit_Constant to NodeVisitor #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2020
Merged

ast: add visit_Constant to NodeVisitor #3767

merged 1 commit into from
Feb 22, 2020

Conversation

hauntsaninja
Copy link
Collaborator

No description provided.

@JelleZijlstra JelleZijlstra merged commit 1fb46cb into python:master Feb 22, 2020
@hauntsaninja hauntsaninja deleted the ast branch February 22, 2020 04:47
@bluetech
Copy link
Contributor

Currently, none of the other visit_* methods exist in the NodeVisitor stub. To me it seems better to either have all or none.

@hauntsaninja
Copy link
Collaborator Author

Technically, none of the other visit_* methods exist; they're potentially discovered through use of getattr. Haven't fully thought it through, but e.g. something (admittedly non-idiomatic) like super().visit_Constant would work.

@bluetech bluetech mentioned this pull request Mar 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hauntsaninja @bluetech @JelleZijlstra