argparse: fix error __init__, add BooleanOptionalAction for py39 #4144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested changes
May 30, 2020
stdlib/2and3/argparse.pyi
Outdated
| class BooleanOptionalAction(Action): | ||
| def __init__( | ||
| self, | ||
| option_strings: Sequence[Text], |
There was a problem hiding this comment.
This is Python 3-only so no real need to use Text
| dest: Text, | ||
| const: Any = ..., | ||
| default: Any = ..., | ||
| type: Optional[Union[Callable[[Text], _T], Callable[[str], _T], FileType]] = ..., |
There was a problem hiding this comment.
Should this class be generic over _T?
There was a problem hiding this comment.
I don't think so? Not sure what that would allows us to accomplish
stdlib/2and3/argparse.pyi
Outdated
| self, | ||
| option_strings: Sequence[Text], | ||
| dest: Text, | ||
| const: Any = ..., |
There was a problem hiding this comment.
I don't fully understand the description of this argument but it sounds like it and default should be of type Optional[_T].
|
Re: the unused in implementation, we'll see what happens python/cpython#11478 (review) |
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Jun 26, 2020
python#4144 and python/cpython#11478 (review) resulted in the issue being fixed upstream. A fix in time saves a branch in typeshed :-)
srittau
pushed a commit
that referenced
this pull request
Jun 26, 2020
#4144 and python/cpython#11478 (review) resulted in the issue being fixed upstream. Co-authored-by: hauntsaninja <>
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
python#4144 and python/cpython#11478 (review) resulted in the issue being fixed upstream. Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.