random.Random: use Any and object for state #6064
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I outlined in #6063, I don't think this change is a good idea. While we prevent false positives when overriding the |
This comment has been minimized.
This comment has been minimized.
|
Makes sense. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6063.
I used
objectas the return value ofgetstate(), because you aren't supposed to rely on what it is, and you can still be more specific in a subclass if you want. Butsetstate()needsAny, because if it would accept an arbitraryobject, then all subclasses would also need to handle arbitraryobjects.There is also module-level
random.getstate()andrandom.setstate()which both useobject. That's fine because they cannot be replaced in a subclass.