stubsabot: Add a warning to the PR message if stubtest is skipped for a distribution #8681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
reviewed
Sep 4, 2022
Co-authored-by: Shantanu <[email protected]>
AlexWaygood
commented
Sep 4, 2022
AlexWaygood
commented
Sep 4, 2022
hauntsaninja
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tend to merge stubsabot PRs pretty quickly if stubtest passes in CI, but if stubtest is skipped for a certain distribution, there's a danger that there might be major changes to the library that we haven't noticed. For these packages, we should be more careful in reviewing PRs from stubsabot.