Thanks to visit codestin.com
Credit goes to github.com

Skip to content

binhex: improve bytes handling - #9035

Merged
JelleZijlstra merged 7 commits into
python:masterfrom
sobolevn:bytes-binhex
Oct 30, 2022
Merged

binhex: improve bytes handling#9035
JelleZijlstra merged 7 commits into
python:masterfrom
sobolevn:bytes-binhex

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 29, 2022

Copy link
Copy Markdown
Member

Source: https://github.com/python/cpython/blob/85f88f63d96b07208c98a725391af7cb710fe06b/Lib/binhex.py#L216-L234

Both write and write_rsrc calls io.open(..., 'wb').write(data)

@AlexWaygood AlexWaygood mentioned this pull request Oct 29, 2022
Merged
@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja requested changes Oct 29, 2022
View reviewed changes

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it calls len. I'd say we should add a _BufferWithLen: TypeAlias = ReadableBuffer to _typeshed (or at least add a comment). This would have been useful in at least one other place

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja approved these changes Oct 29, 2022
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja hauntsaninja mentioned this pull request Oct 29, 2022
Open
@github-actions

github-actions Bot commented Oct 29, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra
JelleZijlstra merged commit a96cb58 into python:master Oct 30, 2022
@AlexWaygood

AlexWaygood commented Oct 30, 2022

Copy link
Copy Markdown
Member

Looks like it calls len. I'd say we should add a _BufferWithLen: TypeAlias = ReadableBuffer to _typeshed (or at least add a comment). This would have been useful in at least one other place

I agree with adding this, but why the leading underscore, out of interest?

@hauntsaninja

hauntsaninja commented Oct 30, 2022

Copy link
Copy Markdown
Collaborator

Oh, I don't remember exactly what rules we have for _typeshed, but I wanted to mark as "private / experimental / do not use"... The type doesn't really correspond to its name, it's currently incorrectly typed (e.g. since ReadableBuffer includes pickle.PickleBuffer), we don't know the fate of PEP 688, etc.

@sobolevn

sobolevn commented Oct 30, 2022

Copy link
Copy Markdown
Member Author

but I wanted to mark as "private / experimental / do not use"...

+1

@AlexWaygood

AlexWaygood commented Oct 30, 2022

Copy link
Copy Markdown
Member

Cool, that makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @AlexWaygood @hauntsaninja @JelleZijlstra