Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump dj-database-url to 1.3.* - #9975

Merged
AlexWaygood merged 5 commits into
mainfrom
stubsabot/dj-database-url
Mar 30, 2023
Merged

Bump dj-database-url to 1.3.*#9975
AlexWaygood merged 5 commits into
mainfrom
stubsabot/dj-database-url

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Release: https://pypi.org/pypi/dj-database-url/1.3.0
Homepage: https://github.com/jazzband/dj-database-url
Diff: jazzband/dj-database-url@v1.2.0...v1.3.0

Stubsabot analysis of the diff between the two releases:

  • 0 public Python files have been added.
  • 0 files included in typeshed's stubs have been deleted.
  • 1 file included in typeshed's stubs has been modified or renamed: dj_database_url.py.
  • Total lines of Python code added: 151.
  • Total lines of Python code deleted: 98.

If stubtest fails for this PR:

  • Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
  • Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI

Release: https://pypi.org/pypi/dj-database-url/1.3.0
Homepage: https://github.com/jazzband/dj-database-url
Diff: jazzband/dj-database-url@v1.2.0...v1.3.0

Stubsabot analysis of the diff between the two releases:
 - 0 public Python files have been added.
 - 0 files included in typeshed's stubs have been deleted.
 - 1 file included in typeshed's stubs has been modified or renamed: `dj_database_url.py`.
 - Total lines of Python code added: 151.
 - Total lines of Python code deleted: 98.

If stubtest fails for this PR:
- Leave this PR open (as a reminder, and to prevent stubsabot from opening another PR)
- Fix stubtest failures in another PR, then close this PR

Note that you will need to close and re-open the PR in order to trigger CI
@hauntsaninja hauntsaninja reopened this Mar 29, 2023
@AlexWaygood AlexWaygood added the help wanted An actionable problem of low to medium complexity where a PR would be very welcome label Mar 29, 2023
@AlexWaygood
AlexWaygood marked this pull request as draft March 29, 2023 00:27
@AlexWaygood

AlexWaygood commented Mar 29, 2023

Copy link
Copy Markdown
Member

It looks like they added inline types in the latest release and added a py.typed file. I haven't verified, but I'm guessing a packaging bug at their end means that it isn't being included in the upload to PyPI, hence why stubsabot isn't trying to mark these stubs as obsolete.

We should figure out what's going on rather than trying to update our stubs, since they're obviously obsolete now.

@AlexWaygood AlexWaygood added status: DO NOT MERGE and removed help wanted An actionable problem of low to medium complexity where a PR would be very welcome labels Mar 29, 2023
@hauntsaninja

Copy link
Copy Markdown
Collaborator

There's no way to add a py.typed to a single file module. They'd need to make it a package (and then also specify package_data in setup.py)

@AlexWaygood

Copy link
Copy Markdown
Member

There's no way to add a py.typed to a single file module. They'd need to make it a package (and then also specify package_data in setup.py)

Good point, that'll be the bug then!

@AlexWaygood

Copy link
Copy Markdown
Member

@AlexWaygood

Copy link
Copy Markdown
Member

In the meantime, I think I will merge this anyway, actually. The updates required from us are very trivial, and the inline types at runtime are still not visible to users, so until jazzband/dj-database-url#214 is resolved, it's still worth our stubs being as up-to-date as possible.

@github-actions

This comment has been minimized.

Comment thread stubs/dj-database-url/@tests/stubtest_allowlist.txt Outdated
@AlexWaygood AlexWaygood changed the title [stubsabot] Bump dj-database-url to 1.3.* Bump dj-database-url to 1.3.* Mar 30, 2023
@AlexWaygood
AlexWaygood marked this pull request as ready for review March 30, 2023 18:16
@github-actions

Copy link
Copy Markdown
Contributor Author

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
AlexWaygood merged commit a06bf1f into main Mar 30, 2023
@AlexWaygood
AlexWaygood deleted the stubsabot/dj-database-url branch March 30, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants