Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Apply get_args fix from bpo-40398 to typing_extensions #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2020
Merged

Apply get_args fix from bpo-40398 to typing_extensions #770

merged 1 commit into from
Dec 23, 2020

Conversation

avalentino
Copy link
Contributor

@avalentino avalentino commented Dec 22, 2020 •
edited by gvanrossum
Loading

Applies the fix from https://bugs.python.org/issue40398 to typing_extensions: typing.get_args() now always returns an empty tuple for special generic aliases.

@avalentino
Backport get_args implementation form Python v3.8
6371eb6 
Fixes bpo-40398: typing.get_args() now always returns an empty
tuple for special generic aliases.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@avalentino

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@gvanrossum
Copy link
Member

Seems this was already done in python/cpython#19857, I presume this PR was submitted by mistake.

@gvanrossum gvanrossum closed this Dec 22, 2020
@avalentino
Copy link
Contributor Author

Actually I need the fix in typing_extensions otherwise I can't use get_args in Python 3.7.

@gvanrossum
Copy link
Member

Okay, reopening. And next time please be a little more clear in what you want. Now go sign that CLA.

@gvanrossum gvanrossum reopened this Dec 23, 2020
@gvanrossum gvanrossum changed the title Backport get_args implementation form Python v3.8 Apply get_args fix from bpo-40398 to typing_extensions Dec 23, 2020
gvanrossum
gvanrossum approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now that I have the right context this is fine.

@gvanrossum gvanrossum merged commit b5c0b6d into python:master Dec 23, 2020
@avalentino
Copy link
Contributor Author

Thanks @gvanrossum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
CLA not signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avalentino @the-knights-who-say-ni @gvanrossum