Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add security documentation #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2024
Merged

Add security documentation #403

merged 4 commits into from
May 16, 2024

Conversation

JelleZijlstra
Copy link
Member

Closes #393.

AlexWaygood
AlexWaygood reviewed May 16, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in SECURITY.md? (The guy in the talk we're in just now said that's where security researchers expect to find this kind of stuff)

@JelleZijlstra
Copy link
Member Author

@AlexWaygood I think we should also add SECURITY.md but I want to talk to someone (Seth?) to confirm the PSRT is OK with dealing with hypothetical security vulnerabilities in typing-extensions.

@JelleZijlstra JelleZijlstra mentioned this pull request May 16, 2024
Closed
AlexWaygood
AlexWaygood approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would probably be fine to add an incomplete SECURITY.md file (with this information in it) and extend it later. But this is also fine!

@hauntsaninja
Copy link
Collaborator

Let's merge this. We should also think about doing https://docs.github.com/en/code-security/security-advisories/guidance-on-reporting-and-writing-information-about-vulnerabilities/privately-reporting-a-security-vulnerability

@JelleZijlstra
Copy link
Member Author

I enabled private vulnerability reporting and added a SECURITY.md pointing to it.

AlexWaygood
AlexWaygood reviewed May 16, 2024
View reviewed changes
@JelleZijlstra @AlexWaygood
Update doc/index.rst
084d2e6 
Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra JelleZijlstra merged commit 910141a into python:main May 16, 2024
@JelleZijlstra JelleZijlstra deleted the securedocs branch May 16, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improving the security of typing-extensions
3 participants
@JelleZijlstra @hauntsaninja @AlexWaygood