allow TypedDict as a type argument #614
Conversation
There was a problem hiding this comment.
I think one thing that would make this code a bit clearer is if we had a custom copy of _SpecialForm (that isn't recognized as such by the code typing.py, maybe called something like _UnrecognizedSpecialForm and documented) and derive from that. This would also make it easier to keep that "fake" special form in sync with the real typing._SpecialForm.
There was a problem hiding this comment.
We already vendor typing._SpecialForm here:
typing_extensions/src/typing_extensions.py
Lines 2204 to 2205 in b07d245
If I move that higher up in the file (so it's defined before _TypedDictSpecialForm) and then make a one-line change so that _TypedDictSpecialForm inherits from _SpecialForm rather than _ExtensionsSpecialForm, all our tests pass and it fixes the issue reported.
This is what we already do to ensure that typing.Type[typing_extensions.Self] is accepted on older versions of Python.
|
Could you also add a comment that this means that this |
|
Thank you! I missed that we already had a |
I tried some more creative solutions but couldn't get anything more concise to work.
Fixes #613.