Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix off by one in pickle protocol tests #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

HexDecimal
Copy link
Contributor

While doing other stuff I've noticed a few tests which I assume are meant to test all pickle protocols but are missing the + 1 needed to test the highest protocol in a range.

This PR adds the highest protocol to these tests.

I've noticed several tests which I assume are meant to test all pickle
protocols but are missing the `+ 1` needed to test the highest protocol
in a range.

This adds the highest protocol to these tests.
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thank you!

@JelleZijlstra JelleZijlstra merged commit 59d2c20 into python:main Jun 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants