Accept valid unicode identifiers as class parameter to make_class #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! How would you summarize the change for the changelog and
? |
|
It's actually just
Attribute name was correctly supported before that patch, it's just my testing code that was incorrect (I was testing a Do you want me to update the patch (if so, where?) or are you going to do the doc/changelog update on your own? btw thanks for the quick answers! |
|
thanks; it was faster to do it myself, than explaining it: fc8b9c6 |
hynek
approved these changes
Feb 9, 2025
luketainton
pushed a commit
to luketainton/pypilot
that referenced
this pull request
Mar 12, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [attrs](https://github.com/python-attrs/attrs) ([changelog](https://www.attrs.org/en/stable/changelog.html)) | project.dependencies | minor | `==25.1.0` -> `==25.2.0` | --- ### Release Notes <details> <summary>python-attrs/attrs (attrs)</summary> ### [`v25.2.0`](https://github.com/python-attrs/attrs/blob/HEAD/CHANGELOG.md#2520---2025-03-12) [Compare Source](python-attrs/attrs@25.1.0...25.2.0) ##### Changes - Checking mandatory vs non-mandatory attribute order is now performed after the field transformer, since the field transformer may change attributes and/or their order. [#​1147](python-attrs/attrs#1147) - `attrs.make_class()` now allows for Unicode class names. [#​1406](python-attrs/attrs#1406) - Speed up class creation by 30%-50% by compiling methods only once and using a variety of other techniques. [#​1407](python-attrs/attrs#1407) - The error message if an attribute has both an annotation and a type argument will now disclose *what* attribute seems to be the problem. [#​1410](python-attrs/attrs#1410) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOTYuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE5Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/316 Reviewed-by: Luke Tainton <[email protected]> Co-authored-by: Renovate [BOT] <[email protected]> Co-committed-by: Renovate [BOT] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1404