Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use multi-phase init #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AA-Turner
Copy link

#174.

cc @arigo -- this is a minimal implementation for _cffi_backend.c. Questions:

  • Can we remove the PY_VERSION checks? It's hard to test the Python-2 case, and as far as I can tell you only support Python 3.8+.
  • Linked to the above, ideally we would consider module isolation, but this requires Python 3-only API that would mean more #if branching, so I've avoided for now.
  • There's a use of single-phase init (PyModule_Create) in vengine_cpy.py, but the file is marked as deprecated. Is the file still used / should I update this?
  • _my_Py_InitModule() and b_init_cffi_1_0_external_module() will be tricky to migrate. Would it be possible to use the dynamic creation functions here instead?

A

@arigo
Copy link
Contributor

arigo commented May 28, 2025

cc @nitzmahone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants