Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#174.
cc @arigo -- this is a minimal implementation for
_cffi_backend.c
. Questions:PY_VERSION
checks? It's hard to test the Python-2 case, and as far as I can tell you only support Python 3.8+.#if
branching, so I've avoided for now.PyModule_Create
) invengine_cpy.py
, but the file is marked as deprecated. Is the file still used / should I update this?_my_Py_InitModule()
andb_init_cffi_1_0_external_module()
will be tricky to migrate. Would it be possible to use the dynamic creation functions here instead?A