extension_testcapi: Ensure python3.lib is generated before linking on Windows
#416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on Windows Follow-up to 5d016e6 ("test_testcapi: Fix build ensuring python3.lib is found", 2025-05-27). This change adds an explicit dependency on `libpython3-shared` to ensure that `python3.lib` is built before linking `extension_testcapi`, preventing potential link errors due to missing or incomplete import libraries. Co-authored-by: Andras Lasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 5d016e6 ("test_testcapi: Fix build ensuring python3.lib is found", 2025-05-27).
This change adds an explicit dependency on
libpython3-sharedto ensure thatpython3.libis built before linkingextension_testcapi, preventing potential link errors due to missing or incomplete import libraries.This should address error initially reported in: