fix(extension_ctypes): Define FFI_BUILDING for static libffi on Windows #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linking against the static `ffi_static` library on Windows requires defining `FFI_BUILDING` to avoid linkage issues, as documented in `ffi.h`. This change restores the behavior that was inadvertently disabled in commit 6478bf3 ("fix(extension_ctypes): Conditionally define FFI_BUILDING", 2025-05-22), ensuring correct linkage for static builds. Additionally, the `HAVE_FFI_CALL` requirement is now restricted to Unix platforms, where the corresponding configure check is performed in `ConfigureChecks.cmake`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking against the static
ffi_staticlibrary on Windows requires definingFFI_BUILDINGto avoid linkage issues, as documented inffi.h.This change restores the behavior that was inadvertently disabled in commit 6478bf3 ("fix(extension_ctypes): Conditionally define FFI_BUILDING", 2025-05-22), ensuring correct linkage for static builds.
Additionally, the
HAVE_FFI_CALLrequirement is now restricted to Unix platforms, where the corresponding configure check is performed inConfigureChecks.cmake.Working toward addressing: