Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minor improvements to prepare for freethreading (no GIL) capabilities #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Minor improvements to prepare for freethreading (no GIL) capabilities #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ebd0441
Added check whether passed solver is an instance of Solver
fjwillemsen Feb 14, 2025
259e004
Switched to poetry-core 2, updated pyproject.toml to use project over…
fjwillemsen Feb 14, 2025
8ad90f7
Updated setuptools, updated dependencies
fjwillemsen Feb 14, 2025
8c0039a
Updated test dependendencies
fjwillemsen Feb 14, 2025
f0e95b4
warning when using GIL in non-threaded mode
fjwillemsen Feb 14, 2025
8643157
Merge branch 'main' into algorithm_improvements
fjwillemsen Feb 14, 2025
cc26aad
Update pyproject.toml
fjwillemsen Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions constraint/problem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@
from constraint.solvers import Solver, OptimizedBacktrackingSolver, ParallelSolver
from constraint.parser import compile_to_constraints

try:
from sys import _is_gil_enabled
freethreading = _is_gil_enabled()
except ImportError:
freethreading = False


class Problem:
"""Class used to define a problem and retrieve solutions."""
Expand All @@ -26,9 +32,14 @@ def __init__(self, solver: Solver=None):
self._str_constraints: list[str] = []
self._variables: dict[Hashable, Domain] = {}

# check if solver is instance instead of class
assert isinstance(self._solver, Solver), f"`solver` is not instance of Solver class (is {type(self._solver)})."

# warn for experimental parallel solver
if isinstance(self._solver, ParallelSolver):
warn("ParallelSolver is currently experimental, and unlikely to be faster than OptimizedBacktrackingSolver. Please report any issues.") # future: remove # noqa E501
if not self._solver._process_mode and not freethreading:
warn("Using the ParallelSolver in ThreadPool mode without freethreading will cause poor performance.")

def reset(self):
"""Reset the current problem definition.
Expand Down
Loading