Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix phase plot lines output #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

murrayrm
Copy link
Member

The phase_plane_plot return value was returning a sublist of lines for equilibrium points and streamlines, so the cplt.lines output looked like

[line1, line2, ..., lineN, [sep1], [sep2] ...]

This PR gets rid of the inner list, so you just get a list of all of the lines (or markers) on the plot, matching the documentation.

@coveralls
Copy link

Coverage Status

coverage: 94.692%. remained the same
when pulling 4f2739d on murrayrm:fix_lines_output-20Nov2024
into d810d5a on python-control:main.

Copy link
Member

@slivingston slivingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I did not find any code in the repository affected by this, which perhaps is why it went unnoticed for a while.

@murrayrm murrayrm merged commit 7649e68 into python-control:main Nov 24, 2024
23 checks passed
@murrayrm murrayrm deleted the fix_lines_output-20Nov2024 branch November 24, 2024 06:49
@murrayrm murrayrm added this to the 0.10.2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants