Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix complex -> real error messages #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

murrayrm
Copy link
Member

This is a small PR that fixes some errors I found when updating the documentation. In two cases, there was a complex-valued array getting used as a real-valued array (and generating an error message):

  • In TransferFunction._common_den, the numerator and denominator polynomial's are computing by extracting poles and zeros and then regenerating polynomials. Because the poles and zeros can be complex, the operations generate a complex-valued array of coefficients. These should be cast back to real coefficients before assigning them back to the real-valued numerator and denominator coefficient arrays. This error showed up in examples/cruise.ipynb, which was also updated to remove the error message in the Output cells.

  • In examples/describing-function.ipynb there was a plot of the describing function for a static nonlinearity. Because describing functions can be complex valued in general (eg, if there is hysteresis), before plotting the value of the real-valued describing function, the results needs to be explicitly cast to real (otherwise you get an error message). This was a small change in the Jupyter notebook.

For the two Jupyter notebooks, all of the plots were also updated, even though they basically look the same => the changes look bigger than they are (and rendering the difference is very slow...).

@coveralls
Copy link

Coverage Status

coverage: 94.73%. remained the same
when pulling 8211905 on murrayrm:fix_complex_to_real-29Dec2024
into 859ece6 on python-control:main.

@slivingston slivingston self-requested a review December 31, 2024 05:43
@murrayrm murrayrm merged commit 4ce7b08 into python-control:main Dec 31, 2024
23 checks passed
@murrayrm murrayrm added this to the 0.10.2 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants