ctrb treats ndim=1 B correctly; ctrb & obsv check input shapes #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Will merge in a bit (just in case someone else wants to take a look). |
slivingston
approved these changes
Jan 20, 2025
|
The suggested change is right, tha ks.
…On Mon, 20 Jan 2025, 05:20 Scott C. Livingston, ***@***.***> wrote:
***@***.**** approved this pull request.
Code is correct. I found a misprint in the test comments. If I simply
misinterpreted the comment, feel free to merge.
------------------------------
In control/tests/statefbk_test.py
<#1099 (comment)>
:
> @@ -79,6 +96,23 @@ def testObsvT(self):
Wo = obsv(A, C, t=t)
np.testing.assert_array_almost_equal(Wo, Wotrue)
+ def testObsvNdim1(self):
+ # gh-1097: treat 1-dim C as 1xn
+ A = np.array([[1., 2.], [3., 4.]])
+ C = np.array([5., 7.])
+ Wotrue = np.array([[5., 7.], [26., 38.]])
+ Wo = obsv(A, C)
+ np.testing.assert_array_almost_equal(Wo, Wotrue)
+
+ def testObsvRejectMismatch(self):
+ # gh-1097: check A, B for compatible shapes
⬇️ Suggested change
- # gh-1097: check A, B for compatible shapes
+ # gh-1097: check A, C for compatible shapes
—
Reply to this email directly, view it on GitHub
<#1099 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3C7QM7AIWRRKUS62XJE32LRTQHAVCNFSM6AAAAABVOMBZOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRRGIZTMMRXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Co-authored-by: Scott C. Livingston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also fixed easy errors pointed out by
pyflakesin the two files I changed; these remain. The first one's obviously a bug, I'll open an issue. Not sure about the second two, probably just oversights?Fixes gh-1097.