Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Travis CI update for new/old scipy + improved slycot #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2018
Merged

Travis CI update for new/old scipy + improved slycot #169

merged 2 commits into from
Jan 2, 2018

Conversation

murrayrm
Copy link
Member

This PR addresses two related issues:

  • The current version of python-control is incompatible with scipy-1.0.0 and so all checks are failing. In this build script we do explicit checks against scipy-0.19.0 and scipy-1.0.0. This is related to issue Compatibility issue with SciPy 1.0 #164.

  • The way that tests were being done against slycot, they were actually not checking to make sure slycot was installed correctly => they 'succeeded' if slycot failed to install. The new version of the build script separates out the slycot versus non-slycot builds so that this is more obvious. Issue Slycot installation failing in Travis CI #168 describes the issue.

In addition to these changes, I updated the python version numbers to check against to 2.7, 3.5, and 3.6 (versions 3.3 and 3.4 seem old enough that we can stop checking against them).

If this PR works correctly, it should have a revised set of Travis CI checks that succeed on the 0.19.1 version of scipy with slicot not installed, but fail on all other cases.

@coveralls
Copy link

coveralls commented Dec 23, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-11.7%) to 65.958% when pulling d4fc2d0 on murrayrm:fix_travis into 05d6bc5 on python-control:master.

@murrayrm
Copy link
Member Author

Check completed as described above.

This was referenced Dec 23, 2017
Closed
Merged
@murrayrm
Copy link
Member Author

Update PR to include new rules for building slycot from source, which allows proper checking against the slycot version of the library. A couple of notes on the implementation:

  • Need to be careful about how to install gfortran and lapack. Install both via apt-get in the root environment (not the test-environment) to make sure that compilers use the right paths (found this out the hard way, but trying almost every other combination of things).

  • Python3 implementations need to have the LIBRARY_PATH environment variable set up properly, otherwise slycot will fail to link properly. For this, you need to link to the version in the local environment, so that you get the right version of python.

While I was at it, I made a few other changes:

  • Reordered the build cases to start with the most up-to-date case (python-3.6, scipy-1.0, slycot) gets tested version.

  • Added more comments throughout to explain what is going on.

  • Don't bother to install conda-build since it is not needed any more.

Some of the Travis builds will still fail for this version since the corrections for scipy-1.0 from PR #164 are not yet included.

@coveralls
Copy link

coveralls commented Dec 24, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 78.379% when pulling b6e378f on murrayrm:fix_travis into 05d6bc5 on python-control:master.

This was referenced Dec 25, 2017
Merged
Closed
@murrayrm murrayrm added this to the 0.8.0 milestone Dec 27, 2017
@murrayrm murrayrm mentioned this pull request Dec 30, 2017
Merged
@murrayrm murrayrm merged commit 7d8bc65 into python-control:master Jan 2, 2018
@murrayrm murrayrm deleted the fix_travis branch January 2, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@murrayrm @coveralls