Performance improvements to _remove_useless_states routine in statesp.py #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adm78
commented
Dec 12, 2018
- avoid looping through states
- significant performance improvement in the creation of large state space models
|
Please let me know if you require any modifications to this PR. It would be great to get it merged into the master branch soon. |
|
Is np.concatenate correct? You could end up with states that are removed for both reasons. |
…tes method This ensures that all elements in the array of state indices to be removed are unique.
|
I'm not sure it's possible but I've replaced the np.concatenate with np.union1d just to be safe. Looks like some of the tests are failing due to slycot import errors... |
|
Travis CI tests are fixed in PR #280. Will merge that into master and then ask pending PRs to merge the change so that we can be sure things are working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.