Only require dataclasses backport for Python < 3.7 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 446 446
Branches 69 69
=========================================
Hits 446 446 Continue to review full report at Codecov.
|
altendky
added a commit
that referenced
this pull request
Jul 28, 2020
rubygems/rubygems#2354 Change noticed while working #103.
|
@altendky @python-desert can this be merged? this issue with dataclasses is breaking our build on python 3.7 and 3.8 as the pip version of dataclasses is getting used rather than the stdlib. |
|
Kick CI for a fresh build. @python-desert, I can't override the required review so it will take someone else's involvement. |
python-desert
approved these changes
Nov 16, 2020
|
Approved |
|
Thanks @altendky! Much appreciated |
|
Still need to get the release, but sure thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102