@nejch I am thinking it might be better to not return anything from block and unblock. As they are supposed to raise Exceptions if something goes wrong. The return values are undocumented. So am leaning towards just returning None. What do you think?

@nejch I am thinking it might be better to not return anything from block and unblock. As they are supposed to raise Exceptions if something goes wrong. The return values are undocumented. So am leaning towards just returning None. What do you think?

I'm thinking it might be best to just return whatever the server returns. This way we don't back ourselves into a corner which seems to have happened with the old lint() method that no longer returns all the fields the server provides:

This way also any breaking changes are only because of GitLab and not us. WDYT?

I'm thinking it might be best to just return whatever the server returns. This way we don't back ourselves into a corner which seems to have happened with the old lint() method that no longer returns all the fields the server provides:

This way also any breaking changes are only because of GitLab and not us. WDYT?

Works for me. I have updated it.

Thanks for the review.

Codecov Report

Merging #2146 (a29cd6c) into main (ed110bd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2146   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          79       79           
  Lines        5149     5149           
=======================================
  Hits         4912     4912           
  Misses        237      237           

Flags with carried forward coverage won't be shown. Click here to find out more.