Autocompute AmbiguousAssignOrExtract as extract
#166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python-graphblas#149 This adds new classes such as `MatrixIndexExpr`, which are able to be auto-computed. PR python-graphblas#157 made this relatively easy. I still need to add a few tests.
|
@jim22k the Louvain notebook is failing sometimes. I don't recall it ever being flaky before. Would you be able to take a look at it when you have the chance? Thanks. In other news, it's nice to see the tests passing again when installing |
Also, allow Scalars (and expressions) to be used in `concat`
|
Alright, this is ready to go in! Yet another fairly large PR that has backwards-incompatible changes. |
|
This is in! I fixed the bug that was affecting Louvain. It's interesting that it only failed some of the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149
This adds new classes such as
MatrixIndexExpr, which are able to be auto-computed. PR #157 made this relatively easy. I still need to add a few tests.