Improve construction when inferring sub-array dtype (a.k.a. array subdtype) #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknw
commented
Feb 3, 2023
| else: | ||
| # If we know the dtype, then using `np.fromiter` is much faster | ||
| dtype = lookup_dtype(dtype) | ||
| values = np.fromiter(iter_values, dtype.np_type) | ||
| if dtype.np_type.subdtype is not None and np.__version__[:5] in {"1.21.", "1.22."}: |
There was a problem hiding this comment.
I think this is the first time we actually use the version of a dependency. This way is pretty low-tech, and hopefully fine. If we need to do more version-dependent behavior, we'll probably want to use a helper utility such as packaging.version.parse.
Also, CI testing of dependency versions FTW!
We can drop 1.21 in June, and 1.22 next January.
|
I need this for another PR (#382), merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us an easy, consistent way to infer sub-array dtypes upon when constructing objects. Also, this handles more cases (I apparently missed some!). See tests for examples.