-
Notifications
You must be signed in to change notification settings - Fork 15
making numba optional #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes unknown |
PyPy 3.8.16 0_73_pypy had a segfault here when using psg wheel, so I'm skipping PyPy on CI for now (not worth the effort). Most of the PyPy jobs were passing though! I'm not sure when I'll be able to push this PR over the finish line, but it's reviewable in its current state. Most of the changes are pretty minor, and it was mostly just grunt-work to get tests to pass w/o numba installed. This PR does not yet introduce "udf" backends or a means to make numba optional when installing. |
Using |
Also, bump version of `fast_matrix_market`, and randomly generate OS for import test.
I think this is ready for review/closer scrutiny. This sets us on the path of having We may want to wait until numba 0.57 is released to merge this. |
I futz around with coverage a little bit, and in the process fixed a few bugs. I also commented code e.g. Anyway, this is going in! I skip numba 0.57.0rc1 on Windows in CI. We can update CI when there is a new RC, and/or when 0.57.0 is released. One final reminder: I am curious whether it's better to use |
I started poking around to see what it would take to allow numba to be optional. Closes #415. May also address #324.
This is a work in progress and can probably be cleaned up. This also tests against Python 3.11 and PyPy.
Let's see what happens in CI!