Thanks to visit codestin.com
Credit goes to github.com

Skip to content

device_id inconsistent across IOT and SMART devices #1348

@ZeliardM

Description

@ZeliardM

I've noticed that the device_id property is inconsistent across the different device types. iotdevice.py uses returns the MAC address when device_id is called, IotStripPlug in iotstrip.py returns a combination of the MAC address and the child_id, and smartdevice.py returns the device_id from sys_info.

I was wondering if there was a reason that the iotdevice.py isn't returning the deviceId from sys_info and for the IotStripPlug in iotstrip.py just returning the child_id? Doing so would be more consistent with the newer smartdevice.py and would still be unique ids as the child_id from my work so far has been the same as the parent deviceId with a two digit version of the child number added to the end of it.

Just curious and a thought, not sure what else it would break though if it was changed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationno-stale

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions