Handle module errors more robustly and add query params to light preset and transition #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## patch #1043 +/- ##
==========================================
+ Coverage 91.44% 91.49% +0.05%
==========================================
Files 84 84
Lines 5739 5775 +36
Branches 1395 1400 +5
==========================================
+ Hits 5248 5284 +36
Misses 382 382
Partials 109 109 ☔ View full report in Codecov by Sentry. |
Merged
sdb9696
added a commit
that referenced
this pull request
Jul 4, 2024
## [0.7.0.3](https://github.com/python-kasa/python-kasa/tree/0.7.0.3) (2024-07-04) [Full Changelog](0.7.0.2...0.7.0.3) Critical bugfix for issue #1033 with ks225 and S505D light preset module errors. Partially fixes light preset module errors with L920 and L930. **Fixed bugs:** Handle module errors more robustly and add query params to light preset and transition [\#1043](#1043)
rytilahti
pushed a commit
that referenced
this pull request
Jul 4, 2024
Fixes the residual issues with the light preset module not handling unexpected `lighting_effect` items in the presets list. Completes the fixes started with PR #1043 to fix #1040, [HA #121115](home-assistant/core#121115) and [HA #121119](home-assistant/core#121119) With this PR affected devices will no longer have the light preset functionality disabled. As this is a new feature this does not warrant a hotfix so will go into the next release. Updated fixture for testing thanks to @szssamuel, many thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #1036 to patch