Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add double click module for smart buttons #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Jan 7, 2025

Enable switching on and off the config option for child buttons double click

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.53%. Comparing base (7b3dde9) to head (cb972c3).
Report is 71 commits behind head on master.

Files with missing lines Patch % Lines
kasa/smart/smartdevice.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
- Coverage   92.56%   92.53%   -0.04%     
==========================================
  Files         132      133       +1     
  Lines        8270     8288      +18     
  Branches      851      851              
==========================================
+ Hits         7655     7669      +14     
- Misses        452      455       +3     
- Partials      163      164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rytilahti
Copy link
Member

@sdb9696 are there some concerns why this shouldn't be merged as-is?

@sdb9696
Copy link
Collaborator Author

sdb9696 commented Mar 6, 2025

Other than fixing the merge conflicts, the outstanding problems are that we don’t get any events from the H200, and we haven’t implemented an event poller/listener for the get_trigger_logs. So setting the double click enablement is not that useful by itself.

Copy link

github-actions bot commented Jun 5, 2025

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added stale and removed stale labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants