Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow sub-command invocation on discovered devices #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rytilahti
Copy link
Member

This allows executing a single sub-command against all discovered devices.
It is not ready to be merged in its current state as it requires figuring out solutions to the issues listed below.

TBD:

  • The sub-command options are not passed to the command
  • When running on discovered devices, the original command on the dummy device needs to be suppressed to avoid crashing

Fixes #71

@rytilahti rytilahti added the bug Something isn't working label Nov 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (f32f7f3) to head (fcfd8d0).
Report is 456 commits behind head on master.

Files with missing lines Patch % Lines
kasa/cli.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   79.88%   78.95%   -0.93%     
==========================================
  Files          24       24              
  Lines        1770     1825      +55     
  Branches      255      266      +11     
==========================================
+ Hits         1414     1441      +27     
- Misses        322      350      +28     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti marked this pull request as draft November 7, 2022 17:12
@rytilahti
Copy link
Member Author

Obsoleted by #982 as it's not a good idea to execute commands on an arbitrary set of devices.

@rytilahti rytilahti closed this Jun 15, 2024
@rytilahti rytilahti deleted the feat/subcommands_on_discovered branch June 15, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual commands do not work on discovered devices
2 participants