Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pretty-print all exceptions from cli commands #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

rytilahti
Copy link
Member

Print out the repr of captured exception instead of full traceback

Fixes #425

Print out the repr of captured exception instead of full traceback
@rytilahti rytilahti added the enhancement New feature or request label Feb 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Base: 79.02% // Head: 79.05% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2b53d8d) compared to base (362c60d).
Patch coverage: 42.85% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   79.02%   79.05%   +0.03%     
==========================================
  Files          24       25       +1     
  Lines        1821     1843      +22     
  Branches      266      268       +2     
==========================================
+ Hits         1439     1457      +18     
- Misses        348      352       +4     
  Partials       34       34              
Impacted Files Coverage Δ
kasa/cli.py 52.15% <42.85%> (-0.28%) ⬇️
kasa/__init__.py 100.00% <0.00%> (ø)
kasa/smartlightstrip.py 93.02% <0.00%> (+0.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rytilahti rytilahti merged commit 92636fe into python-kasa:master Feb 18, 2023
@rytilahti rytilahti deleted the fix/cli_exception_handling branch February 18, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

traceback when no devices exist
2 participants