Memory leak in sasl_interactive_bind interaction callback

The ``interaction`` callback in ``sasl_interactive_bind`` leaks memory.

```
==29355== 118 bytes in 9 blocks are definitely lost in loss record 3,999 of 5,810
==29355==    at 0x4C2FB6B: malloc (vg_replace_malloc.c:299)
==29355==    by 0x5DADBD9: strdup (strdup.c:42)
==29355==    by 0x1485A06A: interaction (LDAPObject.c:575)
==29355==    by 0x1485A06A: py_ldap_sasl_interaction (LDAPObject.c:609)
==29355==    by 0x14A7D90D: ldap_int_sasl_bind (cyrus.c:525)
==29355==    by 0x14A80C7A: ldap_sasl_interactive_bind (sasl.c:487)
==29355==    by 0x14A80E1A: ldap_sasl_interactive_bind_s (sasl.c:521)
==29355==    by 0x1485B828: l_ldap_sasl_interactive_bind_s (LDAPObject.c:728)
==29355==    by 0x4FC24EF: PyCFunction_Call (in /usr/lib64/libpython3.6m.so.1.0)
==29355==    by 0x4FF891C: _PyEval_EvalFrameDefault (in /usr/lib64/libpython3.6m.so.1.0)
```

The memory leak is even documented in the source code

https://github.com/python-ldap/python-ldap/blob/c84b4faf429431cb4d4ef42a156b62d1105f1758/Modules/LDAPObject.c#L569-L577

	/* according to the sasl docs, we should malloc() the returned
	string only for calls where interact->id == SASL_CB_PASS, so we
	probably leak a few bytes per ldap bind. However, if I restrict
	the strdup() to this case, I get segfaults. Should probably be
	fixed sometimes.
	*/
	interact->result = strdup( c_result );
	if (interact->result == NULL)
	return LDAP_OPERATIONS_ERROR;

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Memory leak in sasl_interactive_bind interaction callback #81

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Memory leak in sasl_interactive_bind interaction callback #81

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions