Fix error reporting of LDAPObject.set_option() #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method LDAPObject.set_option() did not signal an exception in case the set option failed. The bug was caused by checking for the wrong error value. The internal C function LDAP_set_option() returns ``1`` for sucess and ``0`` for error, but LDAPObject.set_option() was checking for ``-1``. Add some tests for LDAPObject.set_option() and LDAPObject.get_option(). Closes: python-ldap#100 Signed-off-by: Christian Heimes <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 67.72% 68.04% +0.32%
==========================================
Files 48 48
Lines 4676 4676
Branches 785 785
==========================================
+ Hits 3167 3182 +15
+ Misses 1151 1143 -8
+ Partials 358 351 -7
Continue to review full report at Codecov.
|
Make TestGlobalOptions and TestLDAPObjectOptions peers in the inheritance hierarchy, rather than one deriving from the other.
|
Nice, thanks! Just yesterday I was teaching beginners about the perils of subclassing, so I couldn't resist fixing the inheritance a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method LDAPObject.set_option() did not signal an exception in case
the set option failed. The bug was caused by checking for the wrong
error value. The internal C function LDAP_set_option() returns
1forsucess and
0for error, but LDAPObject.set_option() was checking for-1.Add some tests for LDAPObject.set_option() and LDAPObject.get_option().
Closes: #100
Signed-off-by: Christian Heimes [email protected]