Add handle_signals option to llfuse.main #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikratio
reviewed
Jul 9, 2018
src/fuse_api.pxi
Outdated
| While this function is running, special signal handlers will be installed | ||
| for the *SIGTERM*, *SIGINT* (Ctrl-C), *SIGHUP*, *SIGUSR1* and *SIGPIPE* | ||
| signals. *SIGPIPE* will be ignored, while the other three signals will cause | ||
| *handle_signals* specifies if special signal handlers should be installed |
There was a problem hiding this comment.
That's very hard to read (runaway sentence). Can you just prefix the existing docstring with "Unless handle_signals is False, while this function is running [...]"?
|
Looks good. I agree, there is no way to test this with reasonable effort. Could you improve the docstring and add an entry to ChangeLog.rst? |
|
@Nikratio I've updated the PR 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other point discussed in #13
Regarding how to test this, I'm not sure using
test_fs.pywould be great given this would mean modifyrun_fs(given it's werellfuse.mainis called) and add some test related code there too (typically installing a custom signal handler)...