DEVELOPER_MODE=1 needs to be set manually, fixes #22 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the automatic way caused lots of troubles: - broke travis - often broke tests with specific python versions or OSes By default, we just want to compile it as long as there is nothing serious enough to really break a compiler run. DEVELOPER_MODE=1 can be used on the dev machine to enable more warnings and to be way more strict.
|
this also fixes #27 (the "aborting" part of that). it does not fix that the code uses deprecated functions, but hopefully they will only go away in python 3.10+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the automatic way caused lots of troubles:
By default, we just want to compile it as long as there is nothing
serious enough to really break a compiler run.
DEVELOPER_MODE=1 can be used on the dev machine to enable more warnings
and to be way more strict.