cython3 compatibility #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
158d242 to
ee16d8f
Compare
Note: there are issues with py312 and cy3beta concerning PyThreadState, not sure whether they are caused by Python or Cython or both.
Cython3 does not default to "noexcept" any more.
it seems that we only want to convert the thread_id pointer to the tid ulong for logging purposes. src/llfuse.c:45050:21: warning: incompatible pointer to integer conversion assigning to: 'uintptr_t' (aka 'unsigned long') from: 'pthread_t' (aka 'struct _opaque_pthread_t *') [-Wint-conversion]
0cbafab to
102d475
Compare
|
@mgorny can you review? |
mgorny
approved these changes
May 14, 2023
|
Thanks! |
|
If that wouldn't be a problem, could you make a new release, please? |
|
@mgorny yes, I'll release 1.4.4 soon. |
|
@mgorny 1.4.4 is released, see pypi and github releases. |
|
Thanks a lot! I can confirm that it works for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change source so it compiles on 0.29.x and 3.0 (beta).