Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

akrherz
Copy link
Collaborator

@akrherz akrherz commented Jul 3, 2023

@codecov-commenter
Copy link

Codecov Report

Merging #176 (7dfbe07) into main (8d18917) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files           4        4           
  Lines        1046     1046           
=======================================
  Hits          926      926           
  Misses        120      120           
Impacted Files Coverage Δ
metar/Metar.py 90.19% <100.00%> (ø)

@phobson
Copy link
Collaborator

phobson commented Jul 3, 2023

Thanks for pulling this together. Holding off merging since you didn't actually as for a review yet.

@akrherz akrherz added this to the 1.11.0 milestone Jul 3, 2023
@akrherz
Copy link
Collaborator Author

akrherz commented Jul 3, 2023

@phobson Thanks. I didn't want to tag you so close to a holiday.

@jdkloe
Copy link
Contributor

jdkloe commented Jul 5, 2023

Also from my side thanks for your fast response.
I can confirm that these changes fix the issue in the Fedora configuration, and it now again builds and tests just fine.
See: https://koji.fedoraproject.org/koji/taskinfo?taskID=102904082
So once this is merged #175 can be closed I think.

@akrherz akrherz merged commit f14fec5 into python-metar:main Jul 5, 2023
@akrherz akrherz deleted the python3_12 branch July 5, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants