Prefer command line tools SDK on macOS #5624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Jul 29, 2021
Member
hugovk
left a comment
There was a problem hiding this comment.
I'm still on macOS Mojave 10.14.6, and this builds fine and passes tests.
(I do have /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk)
|
Hey all Just wanted to let you know that this broke the build process in conda-forge. There, we rely on the fact that we can control the MacOS SDK being used (which is explicitly set up by conda-build), but with this patch, the sdk from the system gets preference and ends up breaking (mismatched compiler vs. lib). I reverted it to get conda-forge/pillow-feedstock#101 out the door, but carrying patches indefinitely is not great. Would you like me to open another issue to discuss this? |
Member
Author
|
A new issue would be good, thanks. |
|
Done: #5827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5622