Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate ImagePalette size parameter #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 2 commits into from
Jul 29, 2021
Merged

Deprecate ImagePalette size parameter #5641

mergify merged 2 commits into from
Jul 29, 2021

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Jul 28, 2021

Resolves #5636

The size parameter was originally added in #537. Before #5552, it was there to override a default length check.

Pillow/src/PIL/ImagePalette.py

Lines 45 to 48 in 10615a7

if (size == 0 and len(self.mode) * 256 != len(self.palette)) or (
size != 0 and size != len(self.palette)
):
raise ValueError("wrong palette size")

Afterwards though, the default length check was gone, so size is now just adding an arbitrary constraint on the user - if provided, it throws an error if palette parameter is not the length of the size parmeter.

Pillow/src/PIL/ImagePalette.py

Lines 43 to 44 in 3462b5f

if size != 0 and size != len(self.palette):
raise ValueError("wrong palette size")

@radarhere radarhere mentioned this pull request Jul 28, 2021
Closed
hugovk
hugovk approved these changes Jul 29, 2021
View reviewed changes
@hugovk hugovk added the Deprecation Feature that will be removed in the future label Jul 29, 2021
@radarhere @hugovk
Highlight class name
7c7620d 
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk added the automerge Automatically merge PRs that are ready label Jul 29, 2021
@mergify mergify bot merged commit 71b7f3d into python-pillow:master Jul 29, 2021
@radarhere radarhere deleted the palette_size branch July 30, 2021 00:25
radarhere added a commit to radarhere/Pillow that referenced this pull request Jul 31, 2021
@radarhere
Added release notes for python-pillow#5641
28f54ea
radarhere added a commit to radarhere/Pillow that referenced this pull request Jul 31, 2021
@radarhere
Added release notes for python-pillow#5641
3cf2fff
hugovk added a commit that referenced this pull request Aug 1, 2021
@hugovk
Merge pull request #5648 from radarhere/releasenotes
3346389 
Added release notes for #5641
@radarhere radarhere mentioned this pull request Apr 2, 2022
Merged
@hugovk hugovk mentioned this pull request Apr 2, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

automerge Automatically merge PRs that are ready Deprecation Feature that will be removed in the future Palette

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect documentation for ImagePalette size parameter (and maybe not needed at all)

2 participants

@radarhere @hugovk