Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ubershmekel
Copy link
Contributor

@ubershmekel ubershmekel commented Sep 21, 2025

I'm new to poetry and tried to do poetry new . when I was following https://python-poetry.org/docs/basic-usage/#project-setup in a folder that has some code in it. I got confused as to how to proceed.

Pull Request Check List

Resolves: N/A

  • Added tests for changed code.
  • Updated documentation for changed code.

Summary by Sourcery

Enhancements:

  • Suggest using poetry init when running poetry new in a non-empty directory

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 21, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR enhances the poetry new command by appending a recommendation to use poetry init in the error message when the target directory already exists and is not empty.

Sequence diagram for enhanced error message in 'poetry new' command

sequenceDiagram
actor User
participant "poetry CLI"
participant "new.py command handler"
User->>"poetry CLI": poetry new .
"poetry CLI"->>"new.py command handler": handle()
"new.py command handler"->>"new.py command handler": Check if target directory exists and is not empty
alt Directory exists and is not empty
    "new.py command handler"->>User: Error: Destination <path> exists and is not empty. Did you mean `poetry init`?
else Directory does not exist or is empty
    "new.py command handler"->>"new.py command handler": Proceed with project creation
end
Loading

File-Level Changes

Change Details Files
Suggest using poetry init in the non-empty directory error
  • Extended the RuntimeError message to include “Did you mean poetry init?” suggestion
src/poetry/console/commands/new.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering merged commit 17db1da into python-poetry:main Sep 24, 2025
63 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants