Fix registry for min in buitlins
#242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@apdavison it doesn't tell me why it failed? I just get a weird screen saying testing failed? Could you re-run tests. Since we weren't testing for min before it should be fine. I don't see why test would fail now? |
|
@zm711 thx for the fix. Can you please test this in unit-tests? |
|
Thanks for the push to add a test @twmr :) . I added 'min' into the arithmetic testing since I don't see another great place to add a test. If you have an idea though feel free to point out a better place. |
|
Thx! This was fast! After reading the tests, I think your fix indeed solves my issue reported in #243. Thx @apdavison for linking them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apdavison while working on updating the min the Neo ci discovered that
minis used for minute. So I need to remove that from the builtins. There was no test for this in quantities ci.