Remove --trim option and UImode Enum#169
Merged
Merged
Conversation
Explicitly always make reassignment_nodes the vulnerability chain Fix tests after removing UImode Add comment to argparse hack Update root README.rst
37c28dd to
12619b7
Compare
Collaborator
Author
|
As @bcaller pointed out, we should always trim, and the current code was confusing, this PR cleans all that up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly always make reassignment_nodes the vulnerability chain
Fix tests after removing UImode
Add comment to argparse hack
Update root README.rst