Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ringohoffman
Copy link

Adding an extra new line after each header and between sections fixes the following 2 markdownlint (VS Code, GitHub) errors for changelogs generated by this package:

Copy link
Contributor

@bernardcooke53 bernardcooke53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs commitlint error fixing - thank you! 🚀

Add an extra new line after each header and between sections to fix 2 markdownlint errors
for changelogs generated by this package
@ringohoffman ringohoffman force-pushed the generate-markdown-linter-compliant-changelogs branch from b33bdd2 to a27bf0c Compare May 28, 2023 16:28
@ringohoffman
Copy link
Author

@bernardcooke53 I split it into 2 lines lmk how this works for you

@bernardcooke53
Copy link
Contributor

@ringohoffman works like a charm - thank you!

@bernardcooke53 bernardcooke53 changed the title feat: generate markdown linter compliant changelog headers & lists fix: generate markdown linter compliant changelog headers & lists May 28, 2023
@bernardcooke53 bernardcooke53 merged commit 9d9d403 into python-semantic-release:master May 28, 2023
ringohoffman pushed a commit to ringohoffman/python-semantic-release that referenced this pull request May 30, 2023
In python-semantic-release#594, I missed that there are 2 places where the version header is formatted
bernardcooke53 pushed a commit that referenced this pull request Jun 1, 2023
In #594, I missed that there are 2 places where the version header is formatted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants