Add type hints #265
Closed
Add type hints #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
053d920 to
e731da4
Compare
|
@tlaferriere Thanks Thomas for investigating that. As I did lots of changes lately with the upcoming 3.0.0-alpha0, I'd suggest to add your work into one of the next alphas or betas. I think, your work and effort should be preserved. 👍 We only need to make sure we fix all the conflicts. 😉 |
|
Is there a branch for 3.x development I can merge this in? |
|
You could use the |
|
Alright I'll point a pr to the Alpha 0 branch so I can start fixing the conflicts. |
|
That would be awesome! ❤️ Thanks and sorry for all the conflicts. |
|
Closing in favor of tomschr#6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds type hints to every function not deprecated. Should fix #213 .
I've had to refactor some of the code to get mypy to stop complaining on python 3.8. It isn't configured in Tox yet because I am waiting on #247 to be merged to avoid conflicts.