Fix #426: call subclass when deriving from Version #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannystaple
approved these changes
Sep 28, 2023
|
This looks good to me. I totally get investigating CI. |
1f131ec to
cce839a
Compare
When using the replace method, an instance of the Version class is created and not the respective subclass. Co-authored-by: Danny Staple <[email protected]>
cce839a to
5181299
Compare
5181299 to
2dda51c
Compare
|
@dannystaple I could fix the CI problem. Thank you very much for your contribution. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes PR #426
When using the replace method, an instance of the Version class is created and not the subclass. This commit fixes this behavior.
@dannystaple: Could you have a look, please? 🙂
(The CI has currently problems. I'm currently investigating this.)