Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add can_manage_topics for promoteChatMember and Chat* classes #3342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 11, 2022
Merged

Conversation

clot27
Copy link
Member

@clot27 clot27 commented Nov 6, 2022

Adresses the first part of #3340

@harshil21 harshil21 changed the base branch from master to api_6.3_update November 6, 2022 10:26
@clot27
Copy link
Member Author

clot27 commented Nov 7, 2022

uh, why the precommit is failing, it says to format test_chat.py which I didnt even touched, also the precommit tests pass locally

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just smaller comments :)

@Bibo-Joshi Bibo-Joshi merged commit 7cb99c6 into python-telegram-bot:api_6.3_update Nov 11, 2022
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review.

Found some tiny doc inconsistencies, along with a (unintentional?) breaking change.

@harshil21 harshil21 changed the title Some part of the new api update Add can_manage_topics for promoteChatMember and Chat* classes Nov 11, 2022
@harshil21 harshil21 added this to the v20.0a5 milestone Nov 11, 2022
@harshil21 harshil21 added the ⚙️ bot-api affected functionality: bot-api label Nov 11, 2022
Bibo-Joshi added a commit that referenced this pull request Nov 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚙️ bot-api affected functionality: bot-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants