Feat: Docstring changes + moving limit to constants #3343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
reviewed
Nov 7, 2022
telegram/constants.py
Outdated
| @@ -901,3 +901,18 @@ class WebhookLimit(IntEnum): | |||
| """:obj:`int`: Minimum length of the secret token.""" | |||
| MAX_SECRET_TOKEN_LENGTH = 256 | |||
| """:obj:`int`: Maximum length of the secret token.""" | |||
|
|
|||
|
|
|||
| class ChatLimits(IntEnum): | |||
There was a problem hiding this comment.
IIRC we named verything else in singular, i.e. class <…>Limit(enum)
Also add it to the all variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the two docstring changes, I took the opportunity to move the changed limit to constants. At least description can be added to the limit (e.g. in #3336), maybe even more, so I kept the Class name broad.