Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add message_thread_id param to methods, message_thread_id and is_topic_message to Message #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 9, 2022
Merged

add message_thread_id param to methods, message_thread_id and is_topic_message to Message #3345

merged 8 commits into from
Nov 9, 2022

Conversation

lemontree210
Copy link
Member

@lemontree210 lemontree210 commented Nov 6, 2022 •
edited
Loading

addresses #3340

  • Add message_thread_id to methods in Bot and ExtBot
    • add parameter
    • add docstrings with .. versionadded:: version
    • add argument to a call to send_message or item to data
  • Add method to shortcuts (Chat, User...)
  • Create new or adapted existing unit tests - will only be possible when class for topics is created

@lemontree210
feat(Bot, ExtBot) add param message_thread_id
b6f7946 
* haven't added this param to shortcuts yet

* testing doesn't seem to be possible before
ForumTopic class is implemented
Poolitzer
Poolitzer requested changes Nov 6, 2022
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lemontree210 lemontree210 changed the title add message_thread_id parameter add message_thread_id param to methods, message_thread_id and is_topic_message to Message Nov 7, 2022
@lemontree210
Copy link
Member Author

Hey guys, do you maybe think that we should merge this into api_6.3_update and then I'd branch off again when it becomes possible to add tests with real methods and attributes?

@lemontree210 lemontree210 marked this pull request as ready for review November 8, 2022 10:47
Bibo-Joshi
Bibo-Joshi approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One inquery, but the changes LGTM :) can be merged IMO

@Bibo-Joshi Bibo-Joshi merged commit 3e8aa6e into api_6.3_update Nov 9, 2022
@Bibo-Joshi Bibo-Joshi deleted the new_param_message_thread_id_3340 branch November 9, 2022 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Poolitzer Poolitzer Poolitzer requested changes

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemontree210 @Bibo-Joshi @Poolitzer