Support Python 3.13 beta #4253
Support Python 3.13 beta #4253
Conversation
|
If possible we should do #4129 before this is merged so it's easier to change |
ironically if we don't merge this, then all ptb installations on py 3.13 will fail by default. And we don't have python version specific wheels so we can build it on another version and it should be good to go. uses pre-release of cffi 1.17.0 since they don't plan to release the full version until 3.13 rc1 |
|
Merged master so we should be good to go. Also verified that Not sure why type completeness is unhappy. All ruff did was remove some quotes around the annotation and that failed this test apparently. |
Co-authored-by: Bibo-Joshi <[email protected]>
|
All good from my side! |
| @@ -106,7 +106,7 @@ def __init__(self) -> None: | |||
|
|
|||
| self._application: Optional[weakref.ReferenceType[Application]] = None | |||
| self._executor = AsyncIOExecutor() | |||
| self.scheduler: AsyncIOScheduler = AsyncIOScheduler(**self.scheduler_configuration) | |||
| self.scheduler: "AsyncIOScheduler" = AsyncIOScheduler(**self.scheduler_configuration) | |||
There was a problem hiding this comment.
ruff complains about this for me locally (i'm on py 3.13 so that's possibly why now)
|
also forget to mention that for some reason mypy segfaults on my build of python 3.13b1. Does anyone else have the same issue? |
|
Did not try yet ... |
We should probably wait for
cffito release their new version to target 3.13, otherwise passport related functionality won't work. Tracking: python-cffi/cffi#23, python-cffi/cffi#71