Deprecate python-telegram-bot-raw
#4270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil21
requested changes
May 22, 2024
|
Some further typos for the channel post :)
light of day
maintaining
understanding |
clot27
approved these changes
May 31, 2024
|
I built the wheels and double checked the installation on linux & windows. Merging. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses first part of #4129
Manually tested the warnings. Automated testing doesn't seem to be very straight forward at first glance, so I'm willing to skip it …
Draft for a channel post:
Hi all.
We have decided to deprecate the
python-telegram-bot-rawlibrary and no longer provide updates for it.In Februrary 2021, we introduced the library
python-telegram-bot-rawthat provides thetelegrammodule withouttelegram.ext. Back then, we felt this to be right thing to do since the rather new v13 introduced additional required dependencies for theJobQueue.Since then v20 has seen the light of day however. With v20,
python-telegram-botonly has a single required dependency,httpxfor the networking backend. All other dependencies for further functionality oftelegram.extare purely optional. Moreover, according to the numbers that we are aware of ([1], [2], [3], [4]), thepython-telegram-bot-rawlibrary never gained a considerable user base compared topython-telegram-bot.Since maintaining
python-telegram-bot-rawstill consumes some resources and is currently also hindering the modernization of PTBs packaging setup, we have therefore made this decision. The next release of PTB will add a corresponding warning topython-telegram-bot-raw. This will be the last update forpython-telegram-bot-raw.What does this mean to you?
Almost nothing. All you have to do is remove that trailing
-rawfrom your requirements file. That's it. No code changes are necessary, sincepython-telegram-bot-rawis a subset ofpython-telegram-bot. No additional dependencies will be installed.Thank you for your understanding and your continued usage of the
python-telegram-botlibrary.Your PTB Developer Team